Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate empty metadata values by returning value_num == 1 #1438

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Indicate empty metadata values by returning value_num == 1 #1438

merged 2 commits into from
Nov 18, 2019

Conversation

ihnorton
Copy link
Member

No description provided.

@ihnorton
Copy link
Member Author

I guess [ci skip] does not work correctly. Previous build succeeded: https://dev.azure.com/TileDB-Inc/CI/_build/results?buildId=1869

@ihnorton ihnorton requested a review from tdenniston November 18, 2019 19:39
@ihnorton
Copy link
Member Author

@tdenniston I am wondering about backport/API compatibility here.

@tdenniston
Copy link
Contributor

I missed some of the previous discussion, what was the return value for missing keys before this patch? In other words is this technically API breakage?

@ihnorton
Copy link
Member Author

The previous return was 0, but the "no key" indicator was documented as returning value == nullptr.

@tdenniston
Copy link
Contributor

I see, thanks. I think this seems safe to backport, do you see any issues?

@ihnorton
Copy link
Member Author

No, I wanted this approach for API stability, but wanted to double-check.

@tdenniston tdenniston added backport tags commits to backport to release branch C API labels Nov 18, 2019
@tdenniston tdenniston added this to the 1.7.1 milestone Nov 18, 2019
@ihnorton ihnorton merged commit 72738cd into dev Nov 18, 2019
@ihnorton ihnorton deleted the ihn/metadata_emptyval_indicator branch November 18, 2019 21:58
ihnorton added a commit that referenced this pull request Nov 19, 2019
@ihnorton
Add history entry
35b2224 
Also add entry for #1438.
ihnorton added a commit that referenced this pull request Nov 19, 2019
@ihnorton
Add history entry
3478ade 
Also add entry for #1438.
ihnorton added a commit that referenced this pull request Nov 25, 2019
@ihnorton
Add tiledb_array_metadata_has_key function and C++ API
42d78ad 
- Add history entry
- Also add entry for #1438.
ihnorton added a commit that referenced this pull request Nov 25, 2019
@ihnorton
Add tiledb_array_has_metadata_key function and C++ API
5396436 
- Add history entry
- Also add entry for #1438.
ihnorton added a commit that referenced this pull request Nov 25, 2019
@ihnorton
Add tiledb_array_has_metadata_key function and C++ API (#1439)
301efd9 
* Cherry-pick Update HISTORY and version number for 1.7.0 release.

was c8fbf23

* Add tiledb_array_has_metadata_key function and C++ API

- Add history entry
- Also add entry for #1438.
ihnorton added a commit that referenced this pull request Nov 26, 2019
@ihnorton
Indicate empty metadata values by returning value_num == 1 (#1438)
0323f97 
* Indicate empty metadata values by returning value_num == 1

* Fix docs [ci skip]

[ci skip]
ihnorton added a commit that referenced this pull request Nov 26, 2019
@ihnorton
Add tiledb_array_has_metadata_key function and C++ API
93fd276 
- Add history entry
- Also add entry for #1438.
@ihnorton ihnorton removed the backport tags commits to backport to release branch label Jan 8, 2020
@ihnorton ihnorton mentioned this pull request Mar 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavrospapadopoulos stavrospapadopoulos stavrospapadopoulos approved these changes

@tdenniston tdenniston Awaiting requested review from tdenniston

Assignees
No one assigned
Labels
backport-done C API
Projects
None yet
Milestone
1.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ihnorton @tdenniston @stavrospapadopoulos