Removed KV (key-value) functionality #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavrospapadopoulos
force-pushed
the
sp/remove_kv
branch
6 times, most recently
from
b111357 to
cc055e8
Compare
|
What happens if a 1.7 user tries to open a KV created with a previous version? Also, should this change the format version? |
You can open it as an array (and it will work), but the C API for opening it as a KV will be missing.
We could do that. 1.7 adds the new array metadata and removes the KV. |
…nths in a much more efficient way.
stavrospapadopoulos
force-pushed
the
sp/remove_kv
branch
from
cc055e8 to
6fc70bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will add it back in a few months in a much more efficient way.
Closes #1258
Closes #1043
Closes #1029
Closes #760