Add config support for S3 ca_path, ca_file, and verify_ssl options … #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
force-pushed
the
ihn/aws_conf_ca_verifyssl
branch
from
e511f1d to
b8f0624
Compare
|
Not sure why Travis S3 failed. May be due to |
tdenniston
reviewed
Sep 3, 2019
There was a problem hiding this comment.
LGTM mostly -- could you also add the new config params to the https://docs.tiledb.io/en/stable/tutorials/config.html page? We really need to consolidate where these params are listed/documented (but we'll do this in a separate PR at some point).
ihnorton
force-pushed
the
ihn/aws_conf_ca_verifyssl
branch
from
b8f0624 to
2220b6e
Compare
done |
ihnorton
force-pushed
the
ihn/aws_conf_ca_verifyssl
branch
from
2220b6e to
f33611f
Compare
tdenniston
reviewed
Sep 4, 2019
ihnorton
force-pushed
the
ihn/aws_conf_ca_verifyssl
branch
4 times, most recently
from
4b1799b to
85b4e13
Compare
tdenniston
reviewed
Sep 4, 2019
Corresponding to Aws::Client::ClientConfiguration caPath, caFile, and verifySSL struct fields.
- create and utilize certificate files as documented in: https://docs.min.io/docs/how-to-secure-access-to-minio-server-with-tls - use ECDSA cert instead of RSA ref: github.com/minio/minio/issues/6611 - add test certificates to repository - adjust tests to use certs (one each for ca_file and ca_path) or to pass `verify_ssl = false`.
ihnorton
force-pushed
the
ihn/aws_conf_ca_verifyssl
branch
from
85b4e13 to
7d23cd6
Compare
tdenniston
pushed a commit
that referenced
this pull request
Sep 30, 2019
- create and utilize certificate files as documented in: https://docs.min.io/docs/how-to-secure-access-to-minio-server-with-tls - use ECDSA cert instead of RSA ref: github.com/minio/minio/issues/6611 - add test certificates to repository - adjust tests to use certs (one each for ca_file and ca_path) or to pass `verify_ssl = false`. PR #1376 (cherry picked from commit aa5be3a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add configuration support for the AWS S3/cURL ca_path, ca_file, and verify_ssl options:
http://sdk.amazonaws.com/cpp/api/LATEST/struct_aws_1_1_client_1_1_client_configuration.html#a668718b2027712b56cc1019161293f9c
test minio with HTTPS: add CI script support, test certificates, and update tests to use certificates or
verify_ssl = false