Fixed bug with sparse global order writes when the buffer sizes are zero #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavrospapadopoulos
force-pushed
the
sp/bug_global_writes_zero_sizes
branch
from
cebe6b0 to
ac10f33
Compare
tdenniston
reviewed
May 8, 2019
stavrospapadopoulos
force-pushed
the
sp/bug_global_writes_zero_sizes
branch
from
ac10f33 to
df093f1
Compare
ihnorton
approved these changes
May 8, 2019
jakebolewski
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was also affecting consolidation (when iteratively reading empty sparse regions and attempting to write with zero-sized buffers).