Don't link shared zlib when it was built w/ superbuild #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build-in module does not support zlibstatic, so it finds zlib.lib/dll on the second pass, which we do not want to link when building with superbuild (e.g. for binding libraries).
ihnorton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built-in module does not support zlibstatic, so it finds
zlib.lib/dll on the second pass (instead of zlibstatic). I think we should avoid linking zlib.dll
when building with superbuild, preferring zlibstatic. The binary releases do not link zlib.dll, and avoiding the linkage simplifies binding distribution and reduces risk of dll conflict (esp on windows).