Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AWS credentials in tiledb config #1036

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Support AWS credentials in tiledb config #1036

merged 1 commit into from
Oct 30, 2018

Conversation

Shelnutt2
Copy link
Member

Support AWS credentials in tiledb config #1033

tdenniston
tdenniston suggested changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@tdenniston tdenniston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add these parameters to the blacklist (

TileDB/tiledb/sm/storage_manager/config.cc

Line 51 in 4ae5cd4

const std::set<std::string> Config::unserialized_params_ = {
) so that they are not serialized with the rest of the config params. You'll need to update the config test as well.

@tdenniston tdenniston added this to the 1.5.0 milestone Oct 29, 2018
@Shelnutt2 Shelnutt2 force-pushed the ss/1030-add-aws-key-configs branch 2 times, most recently from 0ccbf69 to 8bd2582 Compare October 29, 2018 15:04
@Shelnutt2 Shelnutt2 force-pushed the ss/1030-add-aws-key-configs branch 2 times, most recently from ba549a6 to 1b2ac92 Compare October 29, 2018 18:49
@Shelnutt2 Shelnutt2 force-pushed the ss/1030-add-aws-key-configs branch from 1b2ac92 to 17150be Compare October 30, 2018 00:55
@tdenniston tdenniston merged commit 33b2ca0 into dev Oct 30, 2018
@tdenniston tdenniston deleted the ss/1030-add-aws-key-configs branch October 30, 2018 12:12
This was referenced Oct 30, 2018
Closed
Closed
@tdenniston tdenniston mentioned this pull request Nov 19, 2018
Closed
@ihnorton ihnorton modified the milestones: 1.5.0, 1.4.2 Feb 19, 2019
@ihnorton ihnorton added the backport tags commits to backport to release branch label Feb 19, 2019
ihnorton pushed a commit that referenced this pull request Feb 19, 2019
@Shelnutt2 @ihnorton
Support AWS credentials in tiledb config #1033
2372a2c 
PR #1036 #1036

(cherry picked from commit 17150be)
@ihnorton ihnorton removed the backport tags commits to backport to release branch label Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdenniston tdenniston tdenniston approved these changes

@jakebolewski jakebolewski jakebolewski approved these changes

Assignees
No one assigned
Labels
config param s3
Projects
None yet
Milestone
1.4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Shelnutt2 @tdenniston @jakebolewski @ihnorton