Set CMAKE_BUILD_TYPE for LZ4/Zlib and Zstd #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have we verified other than zstd that these increase performance? In general we should avoid explicit setting compiler flags where possible. Also for MSVC I think |
Shelnutt2
force-pushed
the
ss/1033-set-cflags-compressors
branch
from
67ade2e to
0714706
Compare
This enables vectorization which yields a boost in performance for these compressors. #1033
Shelnutt2
force-pushed
the
ss/1033-set-cflags-compressors
branch
from
0714706 to
3db1195
Compare
tdenniston
approved these changes
Oct 29, 2018
Shelnutt2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting CMAKE_BUILD_TYPE=Release enables vectorization on gcc 4.8.5, which yields a boost in performance for lz4/zlib/zstd compressors.
Closes #1033