Skip to content

Commit

Permalink
Potential fix for asan spurious failure
Browse files Browse the repository at this point in the history
  • Loading branch information
ypatia committed Jan 10, 2025
1 parent 260fc22 commit 8ffa2cf
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions tiledb/sm/query/readers/reader_base.cc
Original file line number Diff line number Diff line change
Expand Up @@ -929,6 +929,11 @@ Status ReaderBase::unfilter_tiles(

for (size_t i = 0; i < num_tiles; i++) {
auto result_tile = result_tiles[i];

if (skip_field(result_tile->frag_idx(), name)) {
continue;
}

ThreadPool::SharedTask task =
resources_.compute_tp().execute([name,
validity_only,
Expand Down Expand Up @@ -993,11 +998,6 @@ Status ReaderBase::unfilter_tiles(
name, validity_only, result_tile, var_size, nullable);
});

if (skip_field(result_tile->frag_idx(), name)) {
RETURN_NOT_OK(task.wait());
continue;
}

// Unfiltering tasks have been launched, set the tasks to wait for in the
// corresponding tiles. When those tasks(futures) will be ready the tile
// processing that depends on the unfiltered tile will get unblocked.
Expand Down

0 comments on commit 8ffa2cf

Please sign in to comment.