-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Arrays losing CloudArray interface #2144
Bugfix: Arrays losing CloudArray interface #2144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kounelisagis Thank you! I'd like to see the test at https://github.com/TileDB-Inc/TileDB-Cloud-Py/blob/main/tests/test_threaded_import.py moved to the TileDB-Py project to guard against possible future regressions.
tiledb/array.py
Outdated
CloudArray = object | ||
|
||
|
||
class Array(CloudArray): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kounelisagis Great!
e23d31c
to
fee9040
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g2g as long as @sgillies agrees. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kounelisagis ! I ran tiledb-cloud's tests with this branch and the problem is resolved.
This PR fixes the case when
tiledb-cloud
package is present but instances of Dense and Sparse Array are returned without the correct inheritance from:TileDB-Py/tiledb/array.py
Lines 425 to 431 in e1f57bd
[sc-61938]