Propagate resources to ingest_h5ad node #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillies
changed the title
sgillies
commented
Oct 14, 2024
sgillies
commented
Oct 14, 2024
sgillies
commented
Oct 14, 2024
ktsitsi
approved these changes
Oct 15, 2024
|
Will we need a |
gspowley
approved these changes
Oct 15, 2024
johnkerl
approved these changes
Oct 15, 2024
|
@ktsitsi I honestly don't 100% understand why we're doing |
sgillies
added a commit
that referenced
this pull request
Oct 16, 2024
* Take 2: solve the resources propagation problem like VCF does. * Fix docstring * Add code comment about resource propagation and application.
sgillies
added a commit
that referenced
this pull request
Oct 17, 2024
* Skip sub-folders and make pattern more useful * Remove shouty debug log messages * Add more logging. * Test is_dir() before is_file() * Propagate resources to ingest_h5ad node (#669) * Take 2: solve the resources propagation problem like VCF does. * Fix docstring * Add code comment about resource propagation and application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2: solve the resources propagation problem like VCF does. Instead of #664.
Sorry about the churn @johnkerl, @gspowley, @ktsitsi. How about this less risky approach proven in VCF? I'll make the corresponding PR for our 1-click UI.