Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SOMA ingestion's registration race condition. #643

Conversation

JohnMoutafis
Copy link
Contributor

Issue

The SOMA ingest creates a taskgraph called launcher (run_ingest_workflow_udf) that creates the h5ad ingestor task and calls compute on that graph.
That creates a race condition with the ingested SOMA Group registration (initiated from the ingest graph) that results in an empty SOMA although every node of the graph resolves without failures, or in another case in a registration failure (manual registration of that Group showed that the ingestion process was resolved correctly).

Solution

Move the registration inside the launcher process.

Copy link
Collaborator

@sgillies sgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the analysis and description @JohnMoutafis !

@JohnMoutafis JohnMoutafis merged commit 45b018a into main Sep 16, 2024
16 of 18 checks passed
@JohnMoutafis JohnMoutafis deleted the johnmoutafis/sc-55096/cloud-py-fix-race-condition-on-ingested-group branch September 16, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants