Fix SOMA ingestion's registration race condition. #643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The SOMA
ingest
creates a taskgraph calledlauncher
(run_ingest_workflow_udf
) that creates the h5ad ingestor task and callscompute
on that graph.That creates a race condition with the ingested SOMA Group registration (initiated from the
ingest
graph) that results in an empty SOMA although every node of the graph resolves without failures, or in another case in a registration failure (manual registration of that Group showed that the ingestion process was resolved correctly).Solution
Move the registration inside the
launcher
process.