Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions to access new asset listing endpoints. #642

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Add functions to access new asset listing endpoints. #642

merged 3 commits into from
Sep 16, 2024

Conversation

thetorpedodog
Copy link
Contributor

Also includes a separate change regenerating our API code.

@sgillies
Copy link
Collaborator

sgillies commented Sep 12, 2024 •
edited
Loading

@thetorpedodog do the new functions require regeneration of the API? Can you tease these apart? Of course, new endpoints, new YAML. I'm surprised by the number of changed files. Is this with the same version of the API generator as in the committed bash script? Are all of these changes due to updates and improvements in the spec?

@thetorpedodog
Copy link
Contributor Author

Of course, new endpoints, new YAML. I'm surprised by the number of changed files. Is this with the same version of the API generator as in the committed bash script? Are all of these changes due to updates and improvements in the spec?

Yes; this is strictly the result of running ./update_generated.sh (you can try it yourself). It’s a pretty typical diff in my experience.

sgillies
sgillies approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@sgillies sgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thetorpedodog 👍

Shelnutt2
Shelnutt2 reviewed Sep 12, 2024
View reviewed changes
src/tiledb/cloud/asset.py Outdated
type: Optional[_AssetType] = None,
ownership_level: Optional[_OwnershipLevel] = None,
depth: Optional[_Depth] = None,
expand: Optional[str] = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a union of a list or string and we handle the conversion to the csv parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a union of a list or string and we handle the conversion to the csv parameter?

I like this idea.

@JohnMoutafis JohnMoutafis merged commit 3885fd7 into main Sep 16, 2024
14 of 18 checks passed
@JohnMoutafis JohnMoutafis deleted the asset-listing branch September 16, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snagles snagles snagles left review comments

@sgillies sgillies sgillies approved these changes

@Shelnutt2 Shelnutt2 Shelnutt2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thetorpedodog @sgillies @Shelnutt2 @snagles @JohnMoutafis