Experiment with linting / applying patches to generated code #638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint fixes, mostly automated using
git sub
andpre-commit run -a -v
:# noqa: …
commentsimport six
/ Python 2 logicobject
-superclass fromclass
definitionsI understand many of these files are auto-generated, but we already apply one patch (post-
generate_api
).A possible improvement is to maintain a branch, whose commits represent "patches" we want to apply, and use
git rebase
instead ofapply_json_safe_patch
, e.g.:This would allow an arbitrary number of patches to be applied on top of the auto-gen'd docs. Periodically rebasing the "patches" branch (onto
main
) would serve to resolve rebase conflicts once, allowing subsequent rebases to benefit from them.