Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local ingestion and use of run_dag #473

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Local ingestion and use of run_dag #473

merged 5 commits into from
Feb 1, 2024

Conversation

ktsitsi
Copy link
Collaborator

@ktsitsi ktsitsi commented Oct 12, 2023

This PR:

  • introduces a boolean flag local= False for ingesting a bioimg in local mode.
  • substitutes the graph.compute function with it's wrapper run_dag from the utilities._common package

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #25576: Local batch ingestion.

@ktsitsi ktsitsi force-pushed the kt/sc-25576/local-batch-ingestion branch from d31e9ff to f085b3c Compare November 14, 2023 12:38
@ktsitsi ktsitsi force-pushed the kt/sc-25576/local-batch-ingestion branch from 3d3faf4 to dea6aee Compare November 15, 2023 09:54
@ktsitsi ktsitsi mentioned this pull request Dec 12, 2023
Merged
@ktsitsi ktsitsi force-pushed the kt/sc-25576/local-batch-ingestion branch from dea6aee to 1147345 Compare January 22, 2024 11:31
@ktsitsi ktsitsi mentioned this pull request Jan 23, 2024
Merged
@ktsitsi ktsitsi force-pushed the kt/sc-25576/local-batch-ingestion branch from 29e26a3 to 18f84b5 Compare January 23, 2024 10:27
@ktsitsi ktsitsi force-pushed the kt/sc-25576/local-batch-ingestion branch from 06c0311 to bf11342 Compare January 30, 2024 09:19
@ktsitsi ktsitsi requested a review from ihnorton January 30, 2024 09:20
@ktsitsi ktsitsi force-pushed the kt/sc-25576/local-batch-ingestion branch from bf11342 to 8c0fdeb Compare January 30, 2024 09:25
ihnorton
ihnorton approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update.

@ktsitsi ktsitsi merged commit 0ef039e into main Feb 1, 2024
10 of 12 checks passed
@ktsitsi ktsitsi deleted the kt/sc-25576/local-batch-ingestion branch February 1, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

@thetorpedodog thetorpedodog Awaiting requested review from thetorpedodog

Assignees

@thetorpedodog thetorpedodog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktsitsi @ihnorton @thetorpedodog