Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for malformed tiff files #49

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

gsakkis
Copy link
Contributor

@gsakkis gsakkis commented Dec 8, 2022

The CMU-1-Small-Region.ome.tiff test file generated by raw2ometiff had non-standard tile dimensions, which required a workaround in OMETiffWriter to ignore such tiles. This has since been resolved.

This PR replaces the previous CMU-1-Small-Region.ome.tiff with a well-formed one and removes the workaround for malformed tiff files. While at it, the support for reading test files from S3 is also removed as it's not needed anymore.

@gsakkis gsakkis requested review from ihnorton and ktsitsi December 8, 2022 12:14
@ktsitsi
Copy link
Collaborator

ktsitsi commented Dec 8, 2022

Great!

@gsakkis gsakkis merged commit 0835e18 into main Dec 8, 2022
@gsakkis gsakkis deleted the gsa/drop-ome-tiff-workaround branch December 9, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants