Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum files limit? #86

Closed
warmwhisky opened this issue Jul 9, 2019 · 5 comments
Closed

Maximum files limit? #86

warmwhisky opened this issue Jul 9, 2019 · 5 comments
Labels
Milestone

Comments

@warmwhisky
Copy link

I cannot seem to get this to work when I select 460 files. Seems to work with a few like 20 or so.

It has been working fine until today I installed on a windows 10 server workstation. When I choose my preset there is just no response. I tried it on a folder that was not so deep in the server and still the same. Strangely the "configure presets" is also not popping up when I click it after it has failed.

Seems to be doing it on my Windows 7 machine also.

I am trying to downsize jpg by 25% only.

@ivellios1988
Copy link

Same thing happened to me on Windows 10. File Converter just didn't start until I deselected some files.

@Tichau Tichau added the bug label Nov 15, 2020
@Cipriux
Copy link

Cipriux commented Mar 26, 2023

I think I found the reason:
The selected files full path list should not be bigger than 32k something characters
Here is my exact example with empirical testing, this is the exact maximum limit that works on my selections
So there are 445 files selected with the following path structure of maximum character size: 31793 + 445*2 = 32683
I am guessing the limit should be 2^15 = 32768 minus some control characters or memory for some variables

001:f:\2_Downloads\down_net_MJ_temp\123456789_123456789_123456789_001.png
001:f:\2_Downloads\down_net_MJ_temp\123456789_123456789_123456789_002.png
...
444:f:\2_Downloads\down_net_MJ_temp\123456789_123456789_123456789_444a.png
445:f:\2_Downloads\down_net_MJ_temp\123456789_123456789_123456789_445a.png

Making the file path shorter, I managed to convert around 2000 files at once:
f:\1\0001.png
f:\1\0002.png
...
f:\1\1984.png
f:\1\1985.png

I used Total Commander to copy file path list and Sublime Text with LaTeX Word Count plugin to count the characters
I hope it helps someone

@Tichau
Copy link
Owner

Tichau commented Jan 19, 2024

Since FileConverter is launch by command line, there is a limitation about the size the string containing the arguments.

To allow more conversion to be done, we should implement a way of passing files to convert in a text file. For example:
--conversion-preset "To Small Jpg" --input-files "C:\Path\To\Text\File\Containing\Files\List"

@Tichau Tichau added this to the 2.0 milestone Jan 19, 2024
This was referenced Jan 19, 2024
Tichau added a commit that referenced this issue Jan 19, 2024
…t the same time depending on the length of file paths (github issue #86).
@mesheets
Copy link

Might there perhaps be a way to have FileConverter act on files in a directory, possibly with a recursive option? For example, provide:

  • Directory path
  • File type/extension to convert
  • Conversion preset identifier/name
  • Recursive: yes or no

In @Cipriux's example, the files all appear to be under the directory "F:\2_Downloads\down_net_MJ_temp", so a directory-based approach potentially might address that use case.

@Tichau
Copy link
Owner

Tichau commented Jan 19, 2024

This request has been done here if you want to had info: issue #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants