-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Extensions Feature #361
Conversation
I have changed the base branch to be To avoid having to make two separate releases (ie 1.3.1 and then 1.4, or 1.4 and then 1.4.1); if we merge both of these into the staging branch we can merge |
…of the meta sheet in normative documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've raised a question about the short extensions description on the Meta page with potential rewording. I've also suggested a potential rewording of the description, which could wait for the update we will need to make once the Extensions guidance is ready and available to link.
This update to the schema matches what was outlined in the Proposal that was approved by the SC and notice period.
Pending a decision on the suggested rewordings, I'm will be happy to approve this for merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realising we link to a static version of the template with meta sheet. If we're still not able to generate the template with meta, this will need to be updated.
This PR responds to the latest SC approval that an
extensions
array is added to the 360Giving Package Schema (where metadata is):extensions
Each item in the array must be a string. I have also used
uniqueItems: true
to enforce that a publisher cannot accidentally input the same extension twice, this is to support tooling resolving things. If this is out of scope from the SC mandate, I am happy to remove this before merging.I have confirmed:
extensions
is not required["dei", "dei"]
will throw an error