Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to AddOcelot(), Config File Merge #970

Merged
merged 2 commits into from
Jul 28, 2019

Conversation

rjwester
Copy link
Contributor

Fixes / New Feature #296

@CesarD recently brought up a bug in a reply to the old #296 issue. I ran into this issue myself in my own project and made some adjustments to accommodate.

Proposed Changes

  • AddOcelot() now includes the correct config file with the specified environment
    • This was done by removing the excludeConfigName variable and altering the regex
    • The files that will be included would look something like this (assuming a Development env) ocelot.json, ocelot.api.json, ocelot.api.Development.json, etc.

Russell Westeren added 2 commits July 24, 2019 13:06
Added more functionality to configuration files as suggested by CesarD
Clean up
@CesarD
Copy link

CesarD commented Jul 25, 2019

Thanks for taking care of this!

@thiagoloureiro thiagoloureiro merged commit ffecbed into ThreeMammals:develop Jul 28, 2019
thiagoloureiro added a commit that referenced this pull request Jul 28, 2019
thiagoloureiro added a commit that referenced this pull request Jul 28, 2019
@thiagoloureiro
Copy link
Contributor

Had to revert, issues with tests, can you double check please?

@csnance
Copy link

csnance commented Nov 18, 2019

Any update on this? Merging the wrong set of config files by default is a significant issue for me.

Edit: I can workaround the issue by continuing to load the files manually it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants