#653 Adding null check for downstreamResponse

[ben-bartholomew]

Fixes #653

Null reference when pipeline terminates early

Proposed Changes

• In ResponderMiddleware.cs added a check for null downstreamResponse to avoid getting a null ref exception by passing it to SetResponseOnHttpContext
• Added a unit test to make sure SetResponseOnHttpContext does not get called in that case
• Added an acceptance test to make sure that when the pipeline terminates early nothing blows up

[raman-m]

@ben-bartholomew Hi Ben!
Thank you for the fix! 😻
Also, Could you Sync fork please? So, new develop branch will occur with all top commits!
More here: PR 1

@TomPallister Hey Tom!
A new peace of code requires your merging, please! 😉

[ben-bartholomew]

@ben-bartholomew Hi Ben! Thank you for the fix! 😻 Also, Could you Sync fork please? So, new develop branch will occur with all top commits! More here: PR 1

Done, thanks.

[raman-m]

@ben-bartholomew
Thanks for merging!

Have you tried to Sync fork? Is the button enabled?
I don't see develop branch in your fork...

[ben-bartholomew]

@raman-m

I used the sync fork button actually, and that seemed to auto-merge the PR as well.

I'm no GitHub expert but what's the goal is of getting develop to show up in my fork? This PR is coming from a separate bugfix branch, and you merged develop back into it so the bugfix branch should be up to date.

Everything seems good to go here to me, not sure what is missing.

Current state:

[raman-m]

@ben-bartholomew commented on Jul 17, 2023:

I'm no GitHub expert but what's the goal is of getting develop to show up in my fork?

To be able to create feature branch from updated default branch which is develop in head repo.
But your default branch is master, because repo was forked before changing def branch from master to develop.
And you will be able to create from master only.
And you will need to resync to develop branch after a PR creation if the target is develop.

I see, Sync fork button works for current default branch, probably.
To fix that, in future, after PR merging you have to remove this fork, and re-fork once again to get new def branch which is develop one.

---

Update 1

Another user has reported to me a successful syn operation for all branches just today:
https://github.com/Burgyn/Ocelot/branches
And now develop is default branch in his forked repo! 👍

I have an idea!

aka life hack!

Could you create develop branch from your updated master, and after that make develop branch as default one in repo settings.
And after that try to sync fork once again please!
Let me know the results please!

[ben-bartholomew]

To fix that, in future, after PR merging you have to remove this fork, and re-fork once again to get new def branch which is develop one.

I understand now. I assumed this was about changes necessary to get this PR merged since the discussion is happening in the PR thread, and not about getting my fork into some other desired state for potential future PRs.

Let me know the results please!

Easiest way to accomplish this IMO:

git remote add upstream https://github.com/ThreeMammals/Ocelot.git // add original repo as upstream remote
git fetch upstream                                                 // pull changes from original repo
git checkout -b develop upstream/develop                           // pull down develop branch locally
git push -u origin develop                                         // push develop branch to fork

Worked for me. Then downstream repos can set develop as their default branch in GitHub if they want.

[raman-m]

@ben-bartholomew commented on July 17, 2023:

git remote add upstream https://github.com/ThreeMammals/Ocelot.git // add original repo as upstream remote
git fetch upstream                                                 // pull changes from original repo
git checkout -b develop upstream/develop                           // pull down develop branch locally
git push -u origin develop                                         // push develop branch to fork

Worked for me. Then downstream repos can set develop as their default branch in GitHub if they want.

Now I see develop branch in your fork, and it is default. Perfect!
Thanks for the script!
I will definitely keep this script for other users to recover their outdated repos.

[raman-m]

@yilezhu As a bug reporter,

• An exception is thrown when the middleware is rewritten and then blocked back. #653

Could you review the code and verify this bug fix please?