Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple ConfigurationKey for Consul Store KV #384

Closed
Stronhold opened this issue Jun 6, 2018 · 14 comments
Closed

Multiple ConfigurationKey for Consul Store KV #384

Stronhold opened this issue Jun 6, 2018 · 14 comments
Labels
feature A new feature good first issue Should be pretty easy to do help wanted Not actively being worked on. If you plan to contribute, please drop a note. medium effort Likely a few days of development effort wontfix No plan to include this issue in the Ocelot core functionality.

Comments

@Stronhold
Copy link

I would like to know if there can bemultiple configuration keys to access different configuration files in KV Store or if I can match them using a pattern like it is done in issue 296

@TomPallister
Copy link
Member

Hi @Stronhold please see docs here this might help!

@TomPallister TomPallister added the question Initially seen a question could become a new feature or bug or closed ;) label Jun 8, 2018
@Stronhold
Copy link
Author

Stronhold commented Jun 8, 2018

Hi,

I checked that before. As i Saw, there would be only one configurationkey at the same time or am I wrong?

Thanks in advance

@TomPallister
Copy link
Member

TomPallister commented Jun 8, 2018

@Stronhold you can one key per deployment of Ocelot. You cannot merge multiple configurations from Consul at the moment. If you would like to implement this I can support you! 😄

edited: please ignore initial comment.

@Stronhold
Copy link
Author

That was the point! Any help would be appreciated.
Morover, i would like yo know if when we use the administration API, the config.json file, could be overwritten? As far as I have tested, this does not happen

Thanks in advance!

@TomPallister
Copy link
Member

@Stronhold are you using admin api with consul storing your configuration? If so the json file is not changed. If you are not using consul then it will be changed.

@Stronhold
Copy link
Author

Nope. The idea would be using multiple configurationkey and use consul to have the routes. Through the administration API chance the config.json.

Any support to have multiple configurationkey is appreciated :)

@TomPallister
Copy link
Member

Sorry @Stronhold I am very confused by what it is you want to implement. Please could you add as much detail as possible so I can understand.

@Stronhold
Copy link
Author

I want to be able to have múltiple configurationkey to access to different consul configurations and merge them

@TomPallister TomPallister added feature A new feature help wanted Not actively being worked on. If you plan to contribute, please drop a note. good first issue Should be pretty easy to do medium effort Likely a few days of development effort and removed question Initially seen a question could become a new feature or bug or closed ;) labels Jun 13, 2018
@TomPallister
Copy link
Member

TomPallister commented Jun 13, 2018

this feature implement config merging for consul, same logic we use for file merging but applied to consul. put abstraction around logic so we can use same for both concrete implementations.

mrvenus314 pushed a commit to mrvenus314/Ocelot that referenced this issue Sep 10, 2019
To Support Multiple ConfigurationKey for Consul Store KV
@marrop
Copy link

marrop commented Aug 17, 2020

This might be slightly off topic but here goes. Is it possible via Ocelot to read a consul value from Consul's Key/Value store? Or is the only value one may read from Consul the configuration ("InternalConfiguration" or set by "GlobalConfiguration/ConfigurationKey"?)

@raman-m
Copy link
Member

raman-m commented Nov 29, 2023

@ggnaegi What is your opinion on this crazy idea with the Consul config? 😄

@raman-m raman-m added the wontfix No plan to include this issue in the Ocelot core functionality. label Nov 29, 2023
@ggnaegi
Copy link
Member

ggnaegi commented Nov 29, 2023

@ggnaegi What is your opinion on this crazy idea with the Consul config? 😄

I think it would be a nice addition, at least provide a custom key for the ocelot config stored in key/value store.

But then merge config... Like appsettings?

@raman-m
Copy link
Member

raman-m commented Nov 29, 2023

@Stronhold Dear Sergio!
Your request confuses all parties including Tom.
What is your user scenario?

Also, I see that your repos have no Ocelot forked repo.
So, forked Ocelot repo doesn't exist in your account!
I would say you violated Ocelot development process which says: discuss -> issue -> PR.
But working on an issue means you have to fork Ocelot repo.
🆗 First fork, then request...
You have a right to reopen the issue in future.

@raman-m
Copy link
Member

raman-m commented Nov 29, 2023

@ggnaegi

But then merge config... Like appsettings?

I have no idea... We need to ask the author.
But it makes sense to convert this issue to Idea discussion... 😉

@ThreeMammals ThreeMammals locked and limited conversation to collaborators Nov 29, 2023
@raman-m raman-m converted this issue into discussion #1813 Nov 29, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
feature A new feature good first issue Should be pretty easy to do help wanted Not actively being worked on. If you plan to contribute, please drop a note. medium effort Likely a few days of development effort wontfix No plan to include this issue in the Ocelot core functionality.
Projects
None yet
Development

No branches or pull requests

5 participants