Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/Teams api enhancements, Creation of team in Github #22

Open
olivercodes opened this issue Feb 8, 2024 · 0 comments
Open

/Teams api enhancements, Creation of team in Github #22

olivercodes opened this issue Feb 8, 2024 · 0 comments
Assignees

Comments

@olivercodes
Copy link
Member

olivercodes commented Feb 8, 2024

Description:

As an evolution of the creation of teams, we would like to enhance the teams API to include features that simplify the management of team memberships and usage.

Image credit @tomclement

Features:

  • If the GH team exists just associate it in the Teams API record
  • If the GH team doesn't exist, just fail
  • The person creating the team is allowed to do so

Requirements:

  • The implementation of the above features should be done in Github, however the logic included above is abstracted away from the implementation. Similar to how we abstract datastores away from the API (the service and repository layers do not care which datastore is being used under the hood), we would expect someone to be able to implement the teams API with Azure AD or another identity system with relative ease, by implementing the teams api.
  • This will require modifications to the current Teams model, as it now includes the addition of a maintainer (which is a user)
  • Note: it is assumed that the maintainer will proceed to add additional members to the team via the Github Teams interface. This is an advantage to our implementation here, as it greatly reduces the overall complexity of the API, and removes the need to manage individual memberships. Changing of Maintainer (in the event of exiting the company) becomes a (rare) Platform Team operation when needed
@olivercodes olivercodes changed the title /Teams api enhancements /Teams api enhancements, Creation of team in Github Feb 8, 2024
@punitladtw punitladtw self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants