Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method limit_param_set to ValuePoolFuzzer class #7

Merged
merged 5 commits into from
May 30, 2024
Merged

Add method limit_param_set to ValuePoolFuzzer class #7

merged 5 commits into from
May 30, 2024

Conversation

hoegma
Copy link
Collaborator

@hoegma hoegma commented May 30, 2024

  • Implemented limit_param_set method which reduces the number of elements in a param_set to a specified number
  • Tested function by implementing the method into the test function "test_map_range()"

Matthias Högel added 3 commits May 30, 2024 17:49
Add method limit_param_set to ValuePoolFuzzer class
06c5276 
- Implemented limit_param_set method which reduces the number of
  elements in a param_set to a specified number
- Tested function by implementing the method into the test function
  "test_map_range()"
Add method limit_param_set to ValuePoolFuzzer class
df9b195 
- Implemented limit_param_set method which reduces the number of
  elements in a param_set to a specified number
- Tested function by implementing the method into the test function
  "test_map_range()"
Add method limit_param_set to ValuePoolFuzzer class
1cdbd03 
- Implemented limit_param_set method which reduces the number of elements in a param_set to a specified number
- Tested function by implementing the method into the test function "test_map_range()"
ThorbenCarl

This comment was marked as outdated.

Sign in to view

@ThorbenCarl ThorbenCarl self-requested a review May 30, 2024 17:13
ThorbenCarl
ThorbenCarl requested changes May 30, 2024
View reviewed changes
Copy link
Owner

@ThorbenCarl ThorbenCarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short test on mine machine: works. Looks fine to me.

But I would not do it in the ValuePoolFuzzer class. I would do it in the ParamRunner class, so that you can limit sets independent if it comes from the ValuePoolFuzzer

@hoegma hoegma merged commit b78b12a into master May 30, 2024
@ThorbenCarl ThorbenCarl deleted the fuzzing/value_pools-limit_param branch May 31, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThorbenCarl ThorbenCarl ThorbenCarl approved these changes

@JKortmann JKortmann Awaiting requested review from JKortmann

@jonathanheitzmann jonathanheitzmann Awaiting requested review from jonathanheitzmann

@dsiev dsiev Awaiting requested review from dsiev

Assignees

@hoegma hoegma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoegma @ThorbenCarl