Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValuePool Dict as JSON Dict #24

Merged
merged 3 commits into from
Jul 3, 2024
Merged

ValuePool Dict as JSON Dict #24

merged 3 commits into from
Jul 3, 2024

Conversation

jonathanheitzmann
Copy link
Collaborator

@ThorbenCarl can you check if it does now what it should do?
Now it should be consistent as a JSON Dict and not mixed up with a Python Dict.

JKortmann
JKortmann reviewed Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@JKortmann JKortmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try loading this as JSON with json.load(). Do the test cases of the mutational fuzzer run with this changes?

ThorbenCarl
ThorbenCarl approved these changes Jul 3, 2024
View reviewed changes
Copy link
Owner

@ThorbenCarl ThorbenCarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed it as I thought I would.

@ThorbenCarl ThorbenCarl merged commit 7569ac0 into master Jul 3, 2024
@ThorbenCarl ThorbenCarl deleted the ValuePool branch July 4, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKortmann JKortmann JKortmann left review comments

@ThorbenCarl ThorbenCarl Awaiting requested review from ThorbenCarl

Assignees

@jonathanheitzmann jonathanheitzmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathanheitzmann @JKortmann @ThorbenCarl