Add Value Pools and Value Pool Fuzzer #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThorbenCarl
commented
May 20, 2024
There was a problem hiding this comment.
@jonathanheitzmann remove TODOs after editing
There was a problem hiding this comment.
@jonathanheitzmann remove TODOs after editing
| self._STRING_POOL = list(sorted(set(self._STRING_POOL))) | ||
| self._BOOL_POOL = list(sorted(set(self._BOOL_POOL))) | ||
| self._BYTE_POOL = list(sorted(set(self._BYTE_POOL))) | ||
| self._LIST_POOL = list(sorted(set(map(tuple, self._LIST_POOL)))) # lists need to be converted to tuples for set |
There was a problem hiding this comment.
custom_components/test/fuzzing/fuzzer_utils/ValuePool.py:123: in _remove_duplicates
self._LIST_POOL = list(sorted(set(map(tuple, self._LIST_POOL)))) # lists need to be converted to tuples for set
E TypeError: '<' not supported between instances of 'str' and 'bool'
ThorbenCarl
changed the title
ThorbenCarl
changed the title
ThorbenCarl
requested review from
JKortmann,
jonathanheitzmann and
hoegma
and removed request for
JKortmann and
hoegma
Closed
ThorbenCarl
changed the title
|
@jonathanheitzmann I think this commit f23d947 is not working. |
|
Fix value pool fuzzer in faaadb7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New pull request for @jonathanheitzmann