Skip to content
This repository has been archived by the owner on Feb 29, 2024. It is now read-only.

Readme overhaul #304

Merged
merged 5 commits into from
Jul 19, 2022
Merged

Readme overhaul #304

merged 5 commits into from
Jul 19, 2022

Conversation

mulcmu
Copy link
Contributor

@mulcmu mulcmu commented Jul 13, 2022

I started to update the installation steps based on your configuration video and ended up with a lot of changes.

@Thomas55555 Thomas55555 self-requested a review July 14, 2022 08:59
@mulcmu
Copy link
Contributor Author

mulcmu commented Jul 14, 2022

Ready for your review. 2nd commit corrected link that pointed back to my fork for testing.

@Thomas55555
Copy link
Owner

I can't see any changes. Please check your commit.

Update of readme to bring in line with 2022.7.0

Update README.md

screen shot to ../Thomas55555/husqvarna_automower/blob/dev/..

430 XH
@mulcmu mulcmu force-pushed the readme-overhaul branch from 4367e01 to 457cbe2 Compare July 14, 2022 12:31
@mulcmu
Copy link
Contributor Author

mulcmu commented Jul 14, 2022

I squashed the changes into one commit. Do changes show up now?

@Thomas55555
Copy link
Owner

No

@Thomas55555
Copy link
Owner

Did you see my review actually? I think I have just finished it, so you weren't be able to see my change requests?

@mulcmu
Copy link
Contributor Author

mulcmu commented Jul 14, 2022

I did not see you review comments before the squash.

@mulcmu mulcmu marked this pull request as draft July 17, 2022 16:15
@mulcmu mulcmu marked this pull request as ready for review July 17, 2022 17:50
@Thomas55555
Copy link
Owner

I did not see you review comments before the squash.

I just suggested to remove the supported models. People could be irritated, if they see some models without the X.

switch screen shot to `main` branch
@mulcmu
Copy link
Contributor Author

mulcmu commented Jul 18, 2022

I remove the list of models. Still says:

Husqvarna Automowers with built-in Automower® Connect or with the Automower® Connect Module are supported.

@Thomas55555
Copy link
Owner

Thx

@Thomas55555 Thomas55555 merged commit 47875e4 into Thomas55555:main Jul 19, 2022
@mulcmu mulcmu deleted the readme-overhaul branch July 19, 2022 00:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants