Skip to content

Commit

Permalink
Return more useful error when reaching `/api/keystatic/github/created…
Browse files Browse the repository at this point in the history
…-app` route when the GitHub App is already setup (#1364)
  • Loading branch information
emmatown authored Nov 28, 2024
1 parent 0b0864f commit 46d9c55
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/sour-ravens-know.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@keystatic/core': patch
---

Return more useful error when reaching `/api/keystatic/github/created-app` route when the GitHub App is already setup
6 changes: 6 additions & 0 deletions packages/keystatic/src/api/generic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,12 @@ export function makeGenericAPIRouteHandler(
['Set-Cookie', immediatelyExpiringCookie('keystatic-gh-refresh-token')],
]);
}
if (joined === 'github/created-app') {
return {
status: 404,
body: 'It looks like you just tried to create a GitHub App for Keystatic but there is already a GitHub App configured for Keystatic.\n\nYou may be here because you started creating a GitHub App but then started the process again elsewhere and completed it there. You should likely go back to Keystatic and sign in with GitHub to continue.',
};
}
return { status: 404, body: 'Not Found' };
};
}
Expand Down

0 comments on commit 46d9c55

Please sign in to comment.