How to add specific id to builder sections ?

[danyj]

I am trying to assign specific id attribute to sections. I tried to use required option for the id but it seems like is not effective on modals #274 .

Now if I print the builder json I do see that each section in the builder has it's own object.
But the $attr array is returning only the section options.
Is there any way for me to get that object index or anything very specific to each section so that I can generate id's from it inside

framework-customizations\extensions\shortcodes\shortcodes\section\views\view.php

[danyj]

I do see that you are adding the section ID in the builder
http://screencast.com/t/yRSzFKx5e11
but how to add it in frontend?

[danyj]

Any way we can get this to work ?

[danyj]

No suggestion on this one?

[sergiubagrin]

Hi @danyj

We will check it on monday. @moldcraft is missing 3-4 days and i need to discuss with him.

[ghost]

I do see that you are adding the section ID in the builder
http://screencast.com/t/yRSzFKx5e11

That is temporary unique backbone Model.cid. It is lost/auto-generated on page refresh, it is used to find/identify builder item object (for e.g. on sortable drag from one column to another) and it is used only in backend internally.

I am trying to assign specific id attribute to sections.

Sorry for asking that late: Why do you need that?

[danyj]

I am adding all section custom css to head. Background, box model or any section css options. Thus I need the id for each section.

[danyj]

To make it more clear. I am against anything like this http://prntscr.com/6cc57f
All of that belongs in head or inside dynamic CSS.
So in order to keep html clean I used my own class
https://github.com/YJSGframework/yjsg/blob/master/includes/yjsgcore/classes/yjsg.dochead.class.php#L174 ( feel free to use that approach )
and this way I can do this in section/column/row view or any theme file
http://prntscr.com/6cc6jg

and in inc/static.php
I do this
http://prntscr.com/6cc81n
so this way all that inline goes inside of the head embedded
http://prntscr.com/6cc8qj

and html is clean.

Now the auto generated ID for section/column, helps me add css in head for that specific column/section only.

[ghost]

I understood what you want to do.
I will try to figure out a (simple) solution in 1-3 days.

[danyj]

Sure , thank you. On top of my head I saw it somewhere where you are passing the $atts['atts']
$atts['atts']
https://github.com/ThemeFuse/Unyson-Shortcodes-Extension/blob/master/shortcodes/column/includes/page-builder-column-item/class-page-builder-column-item.php

https://github.com/ThemeFuse/Unyson-Shortcodes-Extension/blob/master/shortcodes/section/includes/page-builder-section-item/class-page-builder-section-item.php#L125

if you could just pass this id's as weel to $atts['somekey']
https://github.com/ThemeFuse/Unyson-Shortcodes-Extension/blob/master/shortcodes/section/includes/page-builder-section-item/class-page-builder-section-item.php#L81

https://github.com/ThemeFuse/Unyson-Shortcodes-Extension/blob/master/shortcodes/column/includes/page-builder-column-item/class-page-builder-column-item.php#L74

it would be great. But you know what you are doing. Thank you for the help!

[ghost]

@moldcraft I will try to figure out a (simple) solution in 1-3 days.

Sorry, I haven't done it.

I will do it soon (no more exact promises).

[danyj]

Not a problem. I am busy finalizing all theme options and in week or so will move to page options so it is ok for now.

[ghost]

How/Where do you generate the css?

[danyj]

inside the view I am getting all section/row extra options and using my dochead class to send them to head
http://prntscr.com/6fgmnl

[danyj]

this is basically all I need

$atts['sectionid']  //or 
 $atts['rowid']

[ghost]

How you send them to head inside view? The view is rendered after head when the post content is generated.

[danyj]

:) you did not believe me before , I mentioned it many times, I used my class to do this.
https://github.com/YJSGframework/yjsg/blob/master/includes/yjsgcore/classes/yjsg.dochead.class.php

What my class does is just adding your css to the ['cssinhead'] array,
https://github.com/YJSGframework/yjsg/blob/master/includes/yjsgcore/classes/yjsg.dochead.class.php#L174

and I implode that array in static.php

all css is in its place. it was bit of a hassle but is well worth it and html is clean
I take this

http://prntscr.com/6fgrif

vs this
http://prntscr.com/6cc57f

any time.

[danyj]

oh , and the static.php I use to print everything is not section/static.php

it is theme_name/inc/static.php

[ghost]

I found the solution very simple:

<?php
$auto_id = 'auto-id-'. fw_unique_increment();
ThzDochead::getDocument()->addCssInHead('#'. $auto_id .' { ... }');
?>
<section id="<?php echo $auto_id ?>" ...

or I am missing something?

[danyj]

I was thinking about the same thing and had my own function ( nice to see you have one ) to do that but it does not sit well with me because user might want to add additional css specific to the id and he will never have it right. I know I can add the class for them to style it but if I have 5 sections in the builder this was desired output

thz_section_id0
thz_section_id1
thz_section_id2
thz_section_id3
thz_section_id4

since that is how they are saved in DB for that page
it is an array with keys 0 - 4

is it hard to add the id inside the $attr array ?

[ghost]

is it hard to add the id inside the $attr array ?

Shortcodes doesn't have ids, they are stored as non assoc array.

---

Another solution would be:

1. Copy the hidden option-type to your theme.

2. Rename the type to something like thz-id.

3. Change the _get_value_from_input method to

   protected function _get_value_from_input($option, $input_value)
   {
       if (empty($input_value)) {
           return fw_rand_md5();
       } else {
           return (string)$input_value;
       }
   }

4. Add the option in extensions/shortcodes/shortcodes/section/options.php

   'id' => array( 'type' => 'thz-id' ),

If input value will be empty, it will be generated, if it was already generated. it will stay the same.

[danyj]

ok will try that and by looks of it it might just do what I need. thank you!

[danyj]

about the new issue if builder disabled , i seen it before , thought that is how you wanted since you did not make the short codes available outside the editor

[danyj]

note that I am using the multi picker you last changed
#442 (comment)

[ghost]

multi pickers still dont work properly

some details? what actually doesn't work?

[danyj]

is not taking selected value ,
here video
http://screencast.com/t/b60Hzu26gZ8

[danyj]

the bug is in this check

ThemeFuse/Unyson-Shortcodes-Extension@add95cf#diff-0a666e20f4726c5eb987b41816b00f28R118

if removed the multies work
multies are arrays and value is an array

I used this approach without value set

https://github.com/ThemeFuse/Scratch-Theme/blob/6665e525a060741f7f78908af03e61c4d974851e/scratch-parent/framework-customizations/theme/options/demo-2.php#L948

but even with this it cant find the value
https://github.com/ThemeFuse/Scratch-Theme/blob/6665e525a060741f7f78908af03e61c4d974851e/scratch-parent/framework-customizations/theme/options/demo-2.php#L948

[danyj]

this one to be precise
ThemeFuse/Unyson-Shortcodes-Extension@add95cf#diff-0a666e20f4726c5eb987b41816b00f28R129

[ghost]

Thanks for the investigation. I am already fixing it now. The problem is that it doesn't take in consideration $option['value'] at all, it works only with $input_value, and event doesn't check if $input_value is null (like other options do), it uses it right away.

[ghost]

Fixed multi-picker and other option types.

#275 (comment)
Now we found another problem, because of this (which makes the unique-id option-type _get_value_from_input() method to be executed on every post save) all upload options "lost" their values on post save, because of this.

If I will not find some workaround, I will change the upload and multi-upload options to not ignore $option['value'] (default value set manually, in this case it is set "manually").

I wrote that without verifying/testing. The problem was actually here.

[ghost]

Anything else needed to be fixed in this issue? (except this)

[danyj]

i took an out bud , 2:30 here, will test first thing in the morning and report back

[danyj]

This one is for you
http://prntscr.com/6v66l6

scratch the previous bug report on special heading , seems to work fine

[ghost]

Thank you too, for investigations and feedback.

[ghost]

This (Ctrl+R) will be possible in the next version of Unyson (and page-builder extension).

[danyj]

Nice work. Question , will it work in theme admin when ajax save is on ?

[ghost]

I don't see any connection with Theme Settings.
Give more details pls

[danyj]

I use builder inside theme options , also have section and columns
but save is ajax based not like posts
so I am not sure if I use unique id in there and save via ajax if it will be able to check the uniqueness

[ghost]

It should work.

[danyj]

ok , np , if i have trouble will let you know. thnx for the great work and support.