Add support for HLS videos caching on android #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeboub
approved these changes
Nov 5, 2024
|
looks good to me |
Open
|
Hi @freeboub, I have seen the new version 6.8.0 and the new HLS cache managing from this PR. However, i've seen on this link that caching is not available for .m3u8 yet. Does HLS caching managing is possible on rnv component or not ? If yes, can you share an example of it like a basic rnv component with the option needed. Thanks for your time and have a nice day ! |
|
@douzal34 probably docs were not updated |
|
Still no update on the doc, it's normal @freeboub ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a conditional check whether to include HLS video caching or not for Android devices. We already have a bufferConfig prop that enables caching in most cases, but we don't utilise the useCache variable in case of HLS video streaming.
Motivation
Every time the same HLS video is being played - it gets loaded again and again which is counter-efficient.
Changes
Test plan
Open App Inspector in Android Studio (or proxyman or any other sniffing tool) and check whether HLS videos are getting downloaded with and without bufferConfig prop.