Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Echo HTTP Middleware #93

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Add Echo HTTP Middleware #93

merged 1 commit into from
Feb 4, 2019

Conversation

bafonins
Copy link
Contributor

@bafonins bafonins commented Feb 4, 2019

Summary:
Addresses #84

Changes:

  • Add security headers
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Request-Id: 01D2WWB32R7M7JDZ3E84F8WVCZ
X-Xss-Protection: 1; mode=block
  • Limit body size to 16mb

Notes for Reviewers:
Does not include the gzip compression middleware from the issue

@bafonins bafonins added the compat/api This could affect API compatibility label Feb 4, 2019
@bafonins bafonins self-assigned this Feb 4, 2019
@johanstokking
Copy link
Member

Let's close #84 and open a new issue for gzip.

@johanstokking johanstokking added this to the February 2019 milestone Feb 4, 2019
@bafonins bafonins force-pushed the feature/84-echo-middleware branch from 067d252 to 6152026 Compare February 4, 2019 20:09
@bafonins bafonins merged commit d41a3e5 into master Feb 4, 2019
@bafonins bafonins deleted the feature/84-echo-middleware branch February 4, 2019 20:49
@htdvisser htdvisser mentioned this pull request Mar 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanstokking johanstokking johanstokking approved these changes

Assignees

@bafonins bafonins

Labels
compat/api This could affect API compatibility
Projects
None yet
Milestone
February 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@bafonins @johanstokking