Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot remove all attributes in general settings #7473

Open
wants to merge 1 commit into
base: v3.33
Choose a base branch
from

Conversation

PavelJankoski
Copy link
Contributor

Summary

References #7466

Changes

  • Change the attributes validation to also check empty object.

Testing

Steps

Check if you are gonna be able to remove all the attributes and then click "Save changes".

Results

Changes should be saved successfully and after refreshing the page, the attributes should not be there.

Notes for Reviewers

Beside the device general settings, this was also not working for the gateways and applications, because they all are using the same validation function.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski added the bug Something isn't working label Jan 14, 2025
@PavelJankoski PavelJankoski self-assigned this Jan 14, 2025
@PavelJankoski PavelJankoski requested a review from a team as a code owner January 14, 2025 16:31
@github-actions github-actions bot added the ui/web This is related to a web interface label Jan 14, 2025
@PavelJankoski PavelJankoski changed the title console: Fix cannot remove all attributes in general settings Fix cannot remove all attributes in general settings Jan 14, 2025
@PavelJankoski PavelJankoski added this to the v3.33.1 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant