Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling in user magament in the Console #7448

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

ryaplots
Copy link
Contributor

Summary

This PR fixes an issue spotted by cybereye here: https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1192#issuecomment-2538587453

Changes

  • Add feature check to add button
  • Fix form not handling errors

Testing

Steps
  1. Log in with a user that does not have user create right and go to the user management page - there should be no add user button.
  2. Log in with a user that has the right to create users and try to add a user with an existent id - there should be an error notification in the form.
Results
Screenshot 2024-12-18 at 15 18 23

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the ui/web This is related to a web interface label Dec 18, 2024
@ryaplots ryaplots added this to the v3.33.1 milestone Dec 18, 2024
@ryaplots ryaplots self-assigned this Dec 18, 2024
@ryaplots ryaplots requested a review from a team as a code owner December 18, 2024 14:19
@ryaplots ryaplots force-pushed the fix/user-magament-errors branch from 48d3506 to 4d83f0f Compare January 14, 2025 07:46
@ryaplots ryaplots merged commit 35720e1 into v3.33 Jan 14, 2025
12 of 13 checks passed
@ryaplots ryaplots deleted the fix/user-magament-errors branch January 14, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants