Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check ADR bit in LinkADRAns #7447

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Conversation

halimi
Copy link
Contributor

@halimi halimi commented Dec 17, 2024

Summary

References: #7376

According to the LoRaWAN spec 1.0.3 and 1.0.4 the Network Server should check the ADR bit in the LinkADRAns and based on that decide if the End device rejected the request or not.

Changes

  • Changed the logic in HandleLinkADRAns to use the ADR bit too (if the MAC version is 1.0.3 or 1.0.4) when it checks the ChannelMaskAck, DataRateIndexAck and TxPowerIndexAck bits

Testing

Steps
  • Use an end device that doesn't support ADR
  • Send LinkADRReq command from network server
  • The device should reply with LinkADRAns and the ChannelMaskAck bit should be on and the ADR bit should be off in the uplink FCtrl
  • The network server should mark the answer as accepted and shouldn't send LinkADRReq again
Results
Regressions

...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@halimi halimi self-assigned this Dec 17, 2024
@halimi halimi added this to the v3.33.1 milestone Dec 17, 2024
@github-actions github-actions bot added the c/network server This is related to the Network Server label Dec 17, 2024
@halimi halimi marked this pull request as ready for review December 18, 2024 10:40
@halimi halimi requested a review from a team as a code owner December 18, 2024 10:40
@halimi halimi requested a review from johanstokking December 18, 2024 10:40
@halimi halimi requested a review from johanstokking December 30, 2024 15:29
pkg/specification/macspec/specification.go Outdated Show resolved Hide resolved
pkg/networkserver/mac/link_adr.go Outdated Show resolved Hide resolved
@halimi halimi requested a review from johanstokking January 2, 2025 12:57
@halimi halimi merged commit 013943d into v3.33 Jan 6, 2025
12 of 13 checks passed
@halimi halimi deleted the fix/7376-linkadrreq-adr-bit-check branch January 6, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/network server This is related to the Network Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants