Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notifications dashboard panel #6918

Merged
merged 18 commits into from
Feb 15, 2024
Merged

Add notifications dashboard panel #6918

merged 18 commits into from
Feb 15, 2024

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Feb 6, 2024 •
edited
Loading

Summary

This PR adds the notifications dashboard panel to the dashboard view.

Changes

  • Adjust table to new design
  • Prepare overview view to handle panels
  • Add notifications panel
Screenshot 2024-02-08 at 09 49 50

Testing

  • storybook for table
  • run console for panel

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots self-assigned this Feb 6, 2024
@ryaplots ryaplots requested a review from a team as a code owner February 6, 2024 11:32
@ryaplots ryaplots requested review from mjamescompton and removed request for a team February 6, 2024 11:32
@github-actions github-actions bot added the ui/web This is related to a web interface label Feb 6, 2024
kschiffer
kschiffer suggested changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently broken:
image

Base automatically changed from feature/console-notifications to feature/console-redesign February 7, 2024 10:28
@ryaplots ryaplots force-pushed the feature/notifications-overview-panel branch from 0d852b9 to 111a863 Compare February 7, 2024 12:41
@ryaplots ryaplots requested a review from kschiffer February 7, 2024 13:32
@ryaplots ryaplots force-pushed the feature/notifications-overview-panel branch from 111a863 to 9f5cb67 Compare February 8, 2024 08:49
@ryaplots ryaplots requested a review from kschiffer February 12, 2024 07:05
@ryaplots ryaplots requested a review from a team as a code owner February 14, 2024 10:43
@kschiffer kschiffer force-pushed the feature/notifications-overview-panel branch from 3b35c40 to 0fe5121 Compare February 15, 2024 03:34
@kschiffer kschiffer merged commit 408b319 into feature/console-redesign Feb 15, 2024
12 of 24 checks passed
@kschiffer kschiffer deleted the feature/notifications-overview-panel branch February 15, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschiffer kschiffer kschiffer approved these changes

@mjamescompton mjamescompton Awaiting requested review from mjamescompton mjamescompton is a code owner automatically assigned from TheThingsNetwork/stack-reviewers-3

@pierrephz pierrephz Awaiting requested review from pierrephz

@adriansmares adriansmares Awaiting requested review from adriansmares adriansmares was automatically assigned from TheThingsNetwork/stack-reviewers-4

Assignees

@ryaplots ryaplots

Labels
ui/web This is related to a web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryaplots @kschiffer