Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix database cache key #6846

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Fix database cache key #6846

merged 1 commit into from
Jan 19, 2024

Conversation

adriansmares
Copy link
Contributor

Summary

This PR makes sure that database dumps are have their cache key include the SQL files (so the actual migrations), and the store implementations (so bunstore).

Changes

  • Rename e2e.yml into console-e2e.yml in order to minimize the diff from Enterprise.
  • Fix the cache keys.

Testing

This is relating strictly to development tooling. No manual testing is required.

Regressions

N/A.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.29.0 milestone Jan 19, 2024
@adriansmares adriansmares self-assigned this Jan 19, 2024
@adriansmares adriansmares marked this pull request as ready for review January 19, 2024 16:09
@adriansmares adriansmares requested a review from a team as a code owner January 19, 2024 16:09
nicholaspcr
nicholaspcr approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@nicholaspcr nicholaspcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to approve it

@adriansmares adriansmares merged commit 2276b32 into v3.29 Jan 19, 2024
10 of 11 checks passed
@adriansmares adriansmares deleted the fix/db-cache-key branch January 19, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholaspcr nicholaspcr nicholaspcr approved these changes

@KrishnaIyer KrishnaIyer Awaiting requested review from KrishnaIyer

Assignees

@adriansmares adriansmares

Labels
None yet
Projects
None yet
Milestone
v3.29.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adriansmares @nicholaspcr