-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make contact_info
a read-only field for entities
#6839
Merged
nicholaspcr
merged 30 commits into
v3.29
from
issue/6515-remove-storage-of-contact-info
Jan 22, 2024
Merged
Make contact_info
a read-only field for entities
#6839
nicholaspcr
merged 30 commits into
v3.29
from
issue/6515-remove-storage-of-contact-info
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c/identity server
This is related to the Identity Server
compat/db
This could affect Database compatibility
labels
Jan 19, 2024
nicholaspcr
force-pushed
the
issue/6567-remove-contact-info-validation
branch
2 times, most recently
from
January 19, 2024 16:22
e50c56d
to
e96b7ec
Compare
nicholaspcr
force-pushed
the
issue/6515-remove-storage-of-contact-info
branch
from
January 19, 2024 16:42
8c183ac
to
71182ac
Compare
nicholaspcr
requested review from
adriansmares
and removed request for
a team
January 22, 2024 10:22
adriansmares
approved these changes
Jan 22, 2024
nicholaspcr
force-pushed
the
issue/6515-remove-storage-of-contact-info
branch
from
January 22, 2024 16:41
71182ac
to
9fd031b
Compare
Base automatically changed from
issue/6567-remove-contact-info-validation
to
v3.29
January 22, 2024 17:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c/identity server
This is related to the Identity Server
compat/db
This could affect Database compatibility
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OS counterpart of https://github.com/TheThingsIndustries/lorawan-stack/pull/4023
Changes
Testing
Manual test, unit tests.
Test Steps
Follow the steps below:
user
,application
,gateway
,client
,organization
.2.1. The
administrative_contact
andtechnical_contact
are the user who created the entity.2.2. Command example:
ttn-lw-cli <entity> create --<entity>-id <entity_name> --user-id <user_id>
3.1. Get entity with
--contact-info
fieldmask. Command:ttn-lw-cli <entity> get <entity_id> --contact-info
3.2. List entity with
--contact-info
fieldmask. Command:ttn-lw-cli <entity> list --contact-info
3.3. Search entity with
--contact-info
fieldmask. Command:ttn-lw-cli <entity> search --contact-info
3.4. Attempt to create an entity with a specified
contact_info
.Example of an application with a different contact_info for the step
3.4
:Observation:
For the
user
entity theContactInfo
returned is only composed of the user's primary email address.Regressions
This removes the contact_info operations for all entities. Replacing the contact_info registry with the email_validation registry.
Notes for Reviewers
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.