Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utility classes #6838

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Add utility classes #6838

merged 2 commits into from
Jan 23, 2024

Conversation

PavelJankoski
Copy link
Contributor

Summary

Added utility classes.

Changes

Added general and spacing utility classes.

Notes for Reviewers

Colors utility classes yet to be added with the console redesign.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski added c/console This is related to the Console ui/web This is related to a web interface labels Jan 19, 2024
@PavelJankoski PavelJankoski added this to the v3.29.0 milestone Jan 19, 2024
@PavelJankoski PavelJankoski self-assigned this Jan 19, 2024
@PavelJankoski PavelJankoski requested a review from a team as a code owner January 19, 2024 12:51
kschiffer
kschiffer suggested changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are now some duplicate definitions with pkg/webui/styles/main.styl LL111 which should be removed.

ryaplots
ryaplots approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@ryaplots ryaplots left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I just don't see here the utility classes for colors. Should we also include those? @kschiffer

@kschiffer
Copy link
Contributor

No, they'll all be changed with the token system anyway so I wouldn't want to introduce this soon-to-be legacy code now.

@PavelJankoski PavelJankoski merged commit 9caf20c into v3.29 Jan 23, 2024
12 of 13 checks passed
@PavelJankoski PavelJankoski deleted the feature/add-utility-classes branch January 23, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryaplots ryaplots ryaplots approved these changes

@kschiffer kschiffer kschiffer approved these changes

Assignees

@PavelJankoski PavelJankoski

Labels
c/console This is related to the Console ui/web This is related to a web interface
Projects
None yet
Milestone
v3.29.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PavelJankoski @kschiffer @ryaplots