-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove contact_info
from validation process
#6836
Merged
nicholaspcr
merged 14 commits into
v3.29
from
issue/6567-remove-contact-info-validation
Jan 22, 2024
Merged
Remove contact_info
from validation process
#6836
nicholaspcr
merged 14 commits into
v3.29
from
issue/6567-remove-contact-info-validation
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaspcr
added
c/identity server
This is related to the Identity Server
ui/cli
This is related to ttn-lw-cli
compat/db
This could affect Database compatibility
bump/minor
Needs new minor version for release
ui/web
This is related to a web interface
labels
Jan 16, 2024
nicholaspcr
force-pushed
the
issue/6567-remove-contact-info-validation
branch
2 times, most recently
from
January 16, 2024 22:00
6ef6178
to
cf3b05c
Compare
kschiffer
approved these changes
Jan 18, 2024
This broke the email validation. Please check the end to end tests. |
kschiffer
suggested changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.
nicholaspcr
force-pushed
the
issue/6567-remove-contact-info-validation
branch
2 times, most recently
from
January 19, 2024 15:33
8cad144
to
e50c56d
Compare
nicholaspcr
force-pushed
the
issue/6567-remove-contact-info-validation
branch
from
January 19, 2024 16:22
e50c56d
to
e96b7ec
Compare
kschiffer
approved these changes
Jan 22, 2024
adriansmares
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump/minor
Needs new minor version for release
c/identity server
This is related to the Identity Server
compat/db
This could affect Database compatibility
ui/cli
This is related to ttn-lw-cli
ui/web
This is related to a web interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OS counterpart of https://github.com/TheThingsIndustries/lorawan-stack/pull/4012
Changes
email_validations
tableEmailValidationRegistry
to apiEmailValidationStore
interface to IS's storewebui
to callEmailValidationRegistry
instead ofContactInfoRegistry
when validating emails.Testing
Unit tests and manual testing.
Test Steps
Use the following configuration for the Stack (remember to swap <field_ref> with an appropriate value):
Follow the steps below:
<dir_path>
used in the config to validate if two emails were sent.ttn-lw-cli usr get <usr_id> --primary-email-address --primary-email-address-validated-at
Regressions
N/A
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.