Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console color palette #6808

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Conversation

pierrephz
Copy link
Contributor

Summary

Set up the colors for the new console

Changes

  • Create a new file colors.styl to store the base colors.
  • Remove old color tokens in generic.styl.
  • Create new color tokens in this generic.styl with new color bases and explanation for each.

Notes for Reviewers

We will have to link all the new colors. I am available for a coding session if needed cc @ryaplots

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@pierrephz pierrephz added the ui/web This is related to a web interface label Jan 5, 2024
@pierrephz pierrephz self-assigned this Jan 5, 2024
@pierrephz pierrephz requested a review from a team as a code owner January 5, 2024 10:40
@pierrephz pierrephz requested review from ryaplots and removed request for a team January 5, 2024 10:40
@kschiffer kschiffer force-pushed the feature/color-palette branch from a60e940 to b702e06 Compare January 18, 2024 11:01
@kschiffer
Copy link
Contributor

I've added a couple of commits which will:

  • Add token definitions as CSS variables
  • Add new utility classes that are based on the design tokens
  • Refactor the entire codebase to use CSS variables for colors
  • Refactor the entire codebase to use new utility classes based on design tokens
  • Remove many (now) unused variable and style definitions as well as mixins

After merging this PR, we will use the token CSS variables only as well as respective utility classes.

@kschiffer kschiffer force-pushed the feature/color-palette branch from b702e06 to c72a6a8 Compare January 18, 2024 11:18
@kschiffer kschiffer force-pushed the feature/color-palette branch from c72a6a8 to f0a4a74 Compare January 22, 2024 08:40
@kschiffer kschiffer force-pushed the feature/color-palette branch from f0a4a74 to 4d6e93a Compare January 23, 2024 09:17
@kschiffer kschiffer merged commit c143724 into feature/console-redesign Jan 23, 2024
4 of 6 checks passed
@kschiffer kschiffer deleted the feature/color-palette branch January 23, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants