Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if action/event exist before checking the name #6757

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

KrishnaIyer
Copy link
Member

Summary

Check if action/event exist before checking the name. This is a fix for the undefined ref: https://the-things-industries.sentry.io/issues/4654948021

Changes

  • Check if the action and event objects exist before checking the name.

Testing

NA. I'm not sure when this gets triggered but the check should be sufficient.

Regressions

I'll check on staging.

Notes for Reviewers

  • This seems to me to be a simple code fix but why this callback gets an empty action or event is unclear to me. @PavelJankoski/ @kschiffer

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@KrishnaIyer KrishnaIyer requested a review from a team as a code owner December 11, 2023 11:36
@KrishnaIyer KrishnaIyer self-assigned this Dec 11, 2023
@github-actions github-actions bot added the ui/web This is related to a web interface label Dec 11, 2023
@KrishnaIyer KrishnaIyer added this to the v3.28.2 milestone Dec 11, 2023
@KrishnaIyer KrishnaIyer merged commit c0687cf into v3.28 Dec 11, 2023
13 checks passed
@KrishnaIyer KrishnaIyer deleted the fix/console-event-name-check branch December 11, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants