Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure relay API messages #6753

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Restructure relay API messages #6753

merged 2 commits into from
Dec 11, 2023

Conversation

adriansmares
Copy link
Contributor

@adriansmares adriansmares commented Dec 8, 2023

Summary

References #6721

This PR exists in order to make reviewing the PR above more easier to go through.

Changes

  • Move the ServingRelayParameters.ForwardingLimits and ServingRelayParameters.UplinkForwardingRule to the top level of the API.

Testing

No additional testing is required. This is strictly restructuring the API, without any binary or JSON changes.

Regressions

N/A.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.28.2 milestone Dec 8, 2023
@adriansmares adriansmares self-assigned this Dec 8, 2023
@github-actions github-actions bot added c/network server This is related to the Network Server compat/db This could affect Database compatibility labels Dec 8, 2023
@adriansmares adriansmares marked this pull request as ready for review December 8, 2023 12:33
@adriansmares adriansmares requested a review from a team as a code owner December 8, 2023 12:33
@adriansmares adriansmares force-pushed the feature/relay-api-shake branch from cabfb2a to 3e607c7 Compare December 8, 2023 18:55
@adriansmares adriansmares merged commit 7133999 into v3.28 Dec 11, 2023
16 checks passed
@adriansmares adriansmares deleted the feature/relay-api-shake branch December 11, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/network server This is related to the Network Server compat/db This could affect Database compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants