Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button v2 dropdown enhancement #6727

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

PavelJankoski
Copy link
Contributor

@PavelJankoski PavelJankoski commented Nov 29, 2023

Summary

Changes in button v2 and new dropdown v2 component.

Changes

Added the dropdown, boilerplate, code logic into the component itself. Also created dropdown v2 with minor modifications from the previous dropdown to match the style of the new design.

image
image
image

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski added the ui/web This is related to a web interface label Nov 29, 2023
@PavelJankoski PavelJankoski self-assigned this Nov 29, 2023
@kschiffer
Copy link
Contributor

kschiffer commented Nov 30, 2023

Please always add screenshots to PRs with visual changes.

Copy link
Contributor

@ryaplots ryaplots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PavelJankoski PavelJankoski merged commit f80a595 into feature/new-sidebar Nov 30, 2023
11 of 12 checks passed
@PavelJankoski PavelJankoski deleted the feature/button-v2-enhancement branch November 30, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants