Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect gateway on Gateway Server address change #6726

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

adriansmares
Copy link
Contributor

Summary

References https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1007

Changes

  • Disconnect gateways if the Gateway Server address has changed.

Testing

Local testing. Manual testing steps:

  1. Register a Basic Station gateway. You may use LNS directly or do it via CUPS.
  2. Connect the gateway.
  3. After the gateway has connected, change the gateway server address.
  4. You will have to wait approximately 12 minutes for the periodic check to occur.
  5. Your gateway should disconnect with error gateway_changed.
Regressions

N/A. The gateway server address is covered by the already existing API key rights, so there shouldn't be any regression.

Notes for Reviewers

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.28.2 milestone Nov 29, 2023
@adriansmares adriansmares self-assigned this Nov 29, 2023
@adriansmares adriansmares marked this pull request as ready for review November 29, 2023 16:51
@adriansmares adriansmares requested a review from a team as a code owner November 29, 2023 16:51
@github-actions github-actions bot added the c/gateway server This is related to the Gateway Server label Nov 29, 2023
@adriansmares adriansmares merged commit c24ca19 into v3.28 Nov 30, 2023
13 checks passed
@adriansmares adriansmares deleted the feature/disconnect-on-gateway-server-change branch November 30, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/gateway server This is related to the Gateway Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants