Fix multiple chain rights assertions #6725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes another edge case of the
AssertRights
RPC, specifically the case in which the user has multiple chains of rights towards the entity. This can happen if the user is part of an organization, and the organization is also an entity collaborator, next to the user.Changes
Testing
Local testing and unit testing.
Testing steps (as a non admin user):
Regressions
This fixes a regression caused by the fact that we use the
BatchGetGatewayConnectionStats
in the Console now. No extra regressions are expected.Notes for Reviewers
I've gone again through the logic of getRights and I think this was the final difference between single entity rights assertions and batch rights assertions, but please take another sanity check.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.