-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor old components #6724
Refactor old components #6724
Conversation
1487b3e
to
21fad62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
お疲れ様でした!
This is quite a large diff, so hard to review in detail. The end-to-end tests are passing though. I've checked it out locally as well and didn't see any warnings or issues. We should do some extra scrutiny once this is on staging.
That's fine.
Let's discuss in the frontend meeting. |
Summary
References #6376
Changes
List of refactored components:
/pkg/webui/console/lib/components/with-feature-requirement.js
-> removed/pkg/webui/console/containers/gateway-connection/gateway-connection-reactor.js
-> removed/pkg/webui/lib/components/error-view.js
-> As if now, there is no way to turn functional component into error boundary. Check this threadRemoved every usage of
connect
, except:pkg/webui/lib/components/full-view-error
becauseuseSelector
cannot be used outside of reduxProvider
(there are two usages of that component outside Provider.pkg/webui/console.js
andpkg/webui/account.js
)pkg/webui/account/containers/collaborators-table
andpkg/webui/console/containers/applications-table
. Check what's the correct way to refactor when there is merge props used.Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.