Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: Rollback old http stream #6718

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

PavelJankoski
Copy link
Contributor

Summary

There was an error when trying to import end devices(or calling any other http stream endpoint), because the logic for http streams was removed during web socket changes.

Changes

Rollback of the old logic for http stream.

Testing

  1. Go to console.
  2. Go to /console/applications/:appId/devices/import.
  3. Import a file.
  4. Error should not be shown and everything should work like before.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski added bug Something isn't working ui/web This is related to a web interface labels Nov 21, 2023
@PavelJankoski PavelJankoski self-assigned this Nov 21, 2023
@KrishnaIyer
Copy link
Member

Rolling back is great but we also need to make sure that this is now checked in the frontend tests.

Copy link
Contributor

@kschiffer kschiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed the template converter also uses server side events. I'm also curious how this got through the end-to-end tests. Did you maybe merge before they completed?

@PavelJankoski
Copy link
Contributor Author

Indeed the template converter also uses server side events. I'm also curious how this got through the end-to-end tests. Did you maybe merge before they completed?

Not sure, the ws PR was standing there for some time, the checks should have finished 🤔

@PavelJankoski PavelJankoski merged commit 323b9b2 into v3.28 Nov 22, 2023
12 of 13 checks passed
@PavelJankoski PavelJankoski deleted the fix/rollback-http-stream branch November 22, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants