Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use upstream grpc-gateway/v2 #6715

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Use upstream grpc-gateway/v2 #6715

merged 1 commit into from
Nov 20, 2023

Conversation

adriansmares
Copy link
Contributor

Summary

References #6690 (comment)

Changes

  • Use upstream grpc-gateway/v2.

Testing

Unit testing suffices.

Regressions

N/A. Outside of some dependency updates in grpc-gateway/v2, no other changes between the current fork and the selected commit exists.

Notes for Reviewers

No need to review - CI only.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.28.2 milestone Nov 20, 2023
@adriansmares adriansmares self-assigned this Nov 20, 2023
@github-actions github-actions bot added dependencies Pull requests that update a dependency file tooling Development tooling labels Nov 20, 2023
@adriansmares adriansmares marked this pull request as ready for review November 20, 2023 13:01
@adriansmares adriansmares merged commit 08b6b19 into v3.28 Nov 20, 2023
16 checks passed
@adriansmares adriansmares deleted the feature/upstream-grpc-gateway branch November 20, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanstokking johanstokking Awaiting requested review from johanstokking

Assignees

@adriansmares adriansmares

Labels
dependencies Pull requests that update a dependency file tooling Development tooling
Projects
None yet
Milestone
v3.28.2
Development

Successfully merging this pull request may close these issues.
1 participant
@adriansmares