Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix universal rights effect on batch gateway rights assertions #6711

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

adriansmares
Copy link
Contributor

Summary

This PR fixes the batch gateway rights assertion behavior for admin users.

Admin users have universal rights over entities, but currently batch gateway rights assertion fails if the admin user is not a collaborator of the gateway, as there is no membership chain between the admin user and the gateway. This PR fixes this issue.

Changes

  • Check universal rights as part of the batch gateway rights assertion.

Testing

Manual testing. The steps are somewhat easy in the current v3.28.1.

  1. Register a gateway via a normal user, user a.
  2. Try to view all gateways in the gateway list via an admin user, user b.
  3. You shouldn't see an error (this is currently erroring out in staging1).
Regressions

N/A. This fixes an inconsistency between normal rights and batch rights.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added the bug Something isn't working label Nov 16, 2023
@adriansmares adriansmares added this to the v3.28.1 milestone Nov 16, 2023
@adriansmares adriansmares self-assigned this Nov 16, 2023
@github-actions github-actions bot added the c/identity server This is related to the Identity Server label Nov 16, 2023
@adriansmares adriansmares force-pushed the fix/membership-chains-batch-rights branch from c435958 to ff8989f Compare November 16, 2023 09:54
@adriansmares adriansmares marked this pull request as ready for review November 16, 2023 10:07
@adriansmares adriansmares force-pushed the fix/membership-chains-batch-rights branch from ff8989f to 3001ded Compare November 16, 2023 10:35
@adriansmares adriansmares merged commit fc765de into v3.28 Nov 16, 2023
13 checks passed
@adriansmares adriansmares deleted the fix/membership-chains-batch-rights branch November 16, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/identity server This is related to the Identity Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants