-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple frequency plans to SX1301 config file #6710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
c/gateway conf server
This is related to the Gateway Configuration Server
label
Nov 15, 2023
cvetkovski98
force-pushed
the
feature/multi-freq-sx1301-config-file
branch
from
November 16, 2023 18:47
a2a357f
to
d03137b
Compare
cvetkovski98
requested review from
KrishnaIyer and
adriansmares
as code owners
November 16, 2023 19:03
KrishnaIyer
reviewed
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. We need to test this with some gateways though. We'll get back to you on this.
cvetkovski98
force-pushed
the
feature/multi-freq-sx1301-config-file
branch
from
November 19, 2023 10:43
86d11f8
to
f9073c1
Compare
cvetkovski98
force-pushed
the
feature/multi-freq-sx1301-config-file
branch
from
November 19, 2023 11:03
f9073c1
to
fd88d49
Compare
Moving this to |
adriansmares
approved these changes
Nov 20, 2023
KrishnaIyer
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- For a single gateway, the generated JSON is identical to the current output.
- For multiple gateways, @adriansmares tested with a 16ch gateway and it looks like the gateway reconnected and is working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6652
Changes
global_conf.json
file.Testing
global_conf.json
file for the gateway and ensure there is ansx1301
config entry for every frequency plan.sx1301
field in theglobal_conf.json
file is an array when multiple frequency plans are configured and an object otherwise.Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.