Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure deterministic order of frequency plans #6708

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

cvetkovski98
Copy link
Member

@cvetkovski98 cvetkovski98 commented Nov 15, 2023

Summary

Closes #6614.

Changes

  • Store the gateway frequency plans under io.Connection in an array instead of a map to enforce consistent order

Testing

  • Manual
  • Configure multiple frequency plans for a gateway through the Console or by running ./ttn-lw-cli gtw set <GTW_EUI> --frequency-plan-ids US_902_928_FSB_1,US_902_928_FSB_2.
  • Add a debug log entry for the sx1301_config sent to the gateway on connect and observe the logged value. I added this in lbslns.GetRouterConfig.
  • Ensure the logged value is consistent between multiple reconnects.
  • Running diff on the multiple outputs shows only a difference in the MuxTime.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@cvetkovski98 cvetkovski98 added this to the v3.28.1 milestone Nov 15, 2023
@cvetkovski98 cvetkovski98 self-assigned this Nov 15, 2023
@github-actions github-actions bot added c/gateway server This is related to the Gateway Server c/gateway conf server This is related to the Gateway Configuration Server labels Nov 15, 2023
@cvetkovski98 cvetkovski98 force-pushed the fix/sx1301-deterministic-frequency-plans branch from c4b70d8 to fdd7c53 Compare November 15, 2023 13:48
@cvetkovski98 cvetkovski98 marked this pull request as ready for review November 16, 2023 17:59
Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cvetkovski98 cvetkovski98 merged commit 99f9218 into v3.28 Nov 17, 2023
13 checks passed
@cvetkovski98 cvetkovski98 deleted the fix/sx1301-deterministic-frequency-plans branch November 17, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/gateway conf server This is related to the Gateway Configuration Server c/gateway server This is related to the Gateway Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make order of SX1301 config generated from multiple frequency plans deterministic
3 participants