Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console: Fix fetching stats if there are no gateways #6707

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

PavelJankoski
Copy link
Contributor

Summary

There was an error shown instead of empty table when trying to fetch statistics with empty list.

Changes

Added condition to check, if there are no gateway, don't send request to fetch batch statistics.

Testing

  1. Login in the console.
  2. Go to /console/gateways.
  3. Have an empty slate of not having gateways.
  4. An error should not be shown.

Notes for Reviewers

This was fixed in ENT PR

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski added bug Something isn't working ui/web This is related to a web interface labels Nov 15, 2023
@PavelJankoski PavelJankoski added this to the v3.28.1 milestone Nov 15, 2023
@PavelJankoski PavelJankoski self-assigned this Nov 15, 2023
@PavelJankoski PavelJankoski merged commit 0c91d4b into v3.28 Nov 16, 2023
13 checks passed
@PavelJankoski PavelJankoski deleted the fix/3955-error-fetching-stats branch November 16, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants